From f97dce51a16768e79fccb1a580a546f76361a530 Mon Sep 17 00:00:00 2001 From: Nilstrieb Date: Mon, 7 Jun 2021 15:44:27 +0200 Subject: [PATCH 1/2] removed unnecessary changes --- primes/java/src/DefaultPrimes.java | 2 +- primes/rust/src/main.rs | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/primes/java/src/DefaultPrimes.java b/primes/java/src/DefaultPrimes.java index cf2021a..f51b9f0 100644 --- a/primes/java/src/DefaultPrimes.java +++ b/primes/java/src/DefaultPrimes.java @@ -10,7 +10,7 @@ public class DefaultPrimes implements Primes { primesList.add(2); - for (int i = 3; i < max; i += 2) { //go through all numbers + for (int i = 3; i < max; i++) { //go through all numbers boolean isPrime = true; double sqrRoot = Math.sqrt(i); for (int j = 0; j < primesList.size(); j++) { //test each number diff --git a/primes/rust/src/main.rs b/primes/rust/src/main.rs index e376726..bd1ffdc 100644 --- a/primes/rust/src/main.rs +++ b/primes/rust/src/main.rs @@ -25,9 +25,8 @@ fn primes(max: u32) -> Vec { primes_list.push(2); for mut i in 3..max { - let sqr_root: u32 = (i as f64).sqrt() as u32; for prime in &primes_list { //test each number - if *prime > sqr_root { + if *prime > (i as f64).sqrt() as u32 { primes_list.push(i); break; } @@ -35,7 +34,6 @@ fn primes(max: u32) -> Vec { break; } } - i += 1; } primes_list From bf03c12bb7f963cbb9a4b7aa2f8ad3eacb852d07 Mon Sep 17 00:00:00 2001 From: nils <48135649+Nilstrieb@users.noreply.github.com> Date: Mon, 7 Jun 2021 16:27:29 +0200 Subject: [PATCH 2/2] Update README.md --- primes/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/primes/README.md b/primes/README.md index cb38d83..ccf58c3 100644 --- a/primes/README.md +++ b/primes/README.md @@ -7,5 +7,5 @@ Printing time is not included. | ---------| -------| | Java | 1836ms | | Javascript | 1778ms | -| Rust | 577ms | -| python3 | 34361ms | \ No newline at end of file +| Rust | 577ms (different PC) | +| python3 | 34361ms |