speed up tests by doing rustup which

`cargo test` goes from 2.4s to 1.6s
This commit is contained in:
nora 2023-09-23 16:03:26 +02:00
parent ea5fb6e4ba
commit 50dc094ddd
7 changed files with 99 additions and 34 deletions

View file

@ -7,6 +7,7 @@ edition = "2021"
[dependencies]
anyhow = "1.0.70"
cargo-minimize = { path = ".." }
fs_extra = "1.3.0"
once_cell = "1.17.1"
rayon = "1.7.0"

10
testsuite/README.md Normal file
View file

@ -0,0 +1,10 @@
# testsuite
The test suite works the following way:
We have a bunch of files in `$WORKSPACE/full-tests`, every file is a test. We then run
`cargo-minimize` on that. `~MINIMIZE-ROOT` are required to be present in the minimization,
and we expect `~REQUIRE-DELETED` to be deleted by cargo-minimize.
We use `bin/regression_checked` as our custom script to verify whether it "reproduces", where
for us, "reproduces" means "all roots are present and the code compiles".

View file

@ -1,8 +1,10 @@
use anyhow::bail;
fn main() -> anyhow::Result<()> {
let cargo = std::env::var("MINIMIZE_CARGO").expect("MINIMIZE_CARGO");
if std::env::var("MINIMIZE_LINTS").as_deref() == Ok("1") {
std::process::Command::new("cargo")
std::process::Command::new(&cargo)
.arg("check")
.spawn()
.unwrap()
@ -18,7 +20,7 @@ fn main() -> anyhow::Result<()> {
testsuite::ensure_roots_kept(&proj_dir, roots)?;
let check = std::process::Command::new("cargo")
let check = std::process::Command::new(&cargo)
.arg("check")
.spawn()
.unwrap()

View file

@ -33,7 +33,8 @@ pub fn ensure_roots_kept(
Ok(())
}
fn run_build(command: &mut Command) -> Result<()> {
fn run_build(cargo: &Path, command: &mut Command) -> Result<()> {
command.env("MINIMIZE_CARGO", cargo);
let exit = command
.spawn()
.context("failed to spawn command")?
@ -45,17 +46,22 @@ fn run_build(command: &mut Command) -> Result<()> {
}
pub fn full_tests() -> Result<()> {
run_build(Command::new("cargo").args([
"build",
"-p",
"cargo-minimize",
"-p",
"testsuite",
"--bin",
"regression_checker",
"--bin",
"cargo-minimize",
]))
let cargo = cargo_minimize::rustup_which("cargo")?;
run_build(
&cargo,
Command::new(&cargo).args([
"build",
"-p",
"cargo-minimize",
"-p",
"testsuite",
"--bin",
"regression_checker",
"--bin",
"cargo-minimize",
]),
)
.context("running cargo build")?;
let this_file = Path::new(file!())
@ -94,7 +100,7 @@ pub fn full_tests() -> Result<()> {
.map(|child| {
let path = child.path();
build(&path, &regression_checker_path)
build(&cargo, &path, &regression_checker_path)
.with_context(|| format!("building {:?}", path.file_name().unwrap()))
})
.collect::<Result<Vec<_>>>()?;
@ -102,7 +108,7 @@ pub fn full_tests() -> Result<()> {
for child in children {
let path = child.path();
build(&path, &regression_checker_path)
build(&cargo, &path, &regression_checker_path)
.with_context(|| format!("building {:?}", path.file_name().unwrap()))?;
}
}
@ -110,12 +116,12 @@ pub fn full_tests() -> Result<()> {
Ok(())
}
fn setup_dir(path: &Path) -> Result<(TempDir, PathBuf)> {
fn setup_dir(cargo: &Path, path: &Path) -> Result<(TempDir, PathBuf)> {
let tempdir = tempfile::tempdir()?;
let proj_name = path.file_name().unwrap().to_str().unwrap();
let proj_name = if let Some(proj_name) = proj_name.strip_suffix(".rs") {
let out = Command::new("cargo")
let out = Command::new(cargo)
.arg("new")
.arg(proj_name)
.current_dir(tempdir.path())
@ -143,8 +149,8 @@ fn setup_dir(path: &Path) -> Result<(TempDir, PathBuf)> {
Ok((tempdir, proj_dir))
}
fn build(path: &Path, regression_checker_path: &Path) -> Result<()> {
let (_tempdir, proj_dir) = setup_dir(path).context("setting up tempdir")?;
fn build(cargo: &Path, path: &Path, regression_checker_path: &Path) -> Result<()> {
let (_tempdir, proj_dir) = setup_dir(cargo, path).context("setting up tempdir")?;
let mut cargo_minimize_path = PathBuf::from("target/debug/cargo-minimize");
if cfg!(windows) {
cargo_minimize_path.set_extension("exe");
@ -168,6 +174,7 @@ fn build(path: &Path, regression_checker_path: &Path) -> Result<()> {
let minimize_roots = start_roots.join(",");
cmd.env("MINIMIZE_RUNTEST_ROOTS", &minimize_roots);
cmd.env("MINIMIZE_CARGO", cargo);
let out = cmd.output().context("spawning cargo-minimize")?;
let stderr = String::from_utf8(out.stderr).unwrap();