fix lex test

src/gc.rs

@@ -42,7 +42,7 @@ impl<T: ?Sized> Clone for Gc<T> {
 impl<T: ?Sized> Copy for Gc<T> {}
 
 /// An interned String. Hashing and Equality are O(1) and just look at the pointer address
-#[derive(Debug, Clone, Copy)]
+#[derive(Clone, Copy)]
 pub struct Symbol {
     gc: Gc<str>,
 }
@@ -83,6 +83,12 @@ impl Deref for Symbol {
     }
 }
 
+impl Debug for Symbol {
+    fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        self.as_str().fmt(f)
+    }
+}
+
 #[derive(Debug)]
 struct Object {
     kind: ObjectKind,

src/lex.rs

@@ -353,92 +353,75 @@ fn is_valid_ident_start(char: char) -> bool {
     char.is_alphabetic() || char == '_'
 }
 
-#[cfg(test_ignore)]
+#[cfg(test)]
 mod test {
     use crate::lex::Lexer;
-    use crate::lex::TokenKind::{self, *};
+    use crate::RtAlloc;
 
     type StdString = std::string::String;
 
-    fn lex_types(str: &str) -> Vec<TokenKind> {
-        let lexer = Lexer::new(str);
-        lexer.map(|token| token.kind).collect::<Vec<_>>()
-    }
+    fn lex_test(code: &str) {
+        // SAFETY: we only work in this tiny scope
+        let mut runtime = unsafe { RtAlloc::new() };
 
-    fn lex_test(code: &str, expected: Vec<TokenKind>) {
-        assert_eq!(lex_types(code), expected)
+        let lexer = Lexer::new(code, &mut runtime);
+        let tokens = lexer.map(|token| token.kind).collect::<Vec<_>>();
+
+        insta::assert_debug_snapshot!(tokens);
     }
 
     #[test]
     fn smiley_face() {
-        lex_test(">>.<<", vec![Greater, Greater, Dot, Less, Less])
+        lex_test(">>.<<")
     }
 
     #[test]
     fn greater_than_less_than_equal() {
-        lex_test(
-            ">= <= == < < >=",
-            vec![
-                GreaterEqual,
-                LessEqual,
-                EqualEqual,
-                Less,
-                Less,
-                GreaterEqual,
-            ],
-        )
+        lex_test(">= <= == < < >=")
     }
 
     #[test]
     fn no_no_no() {
-        lex_test("!= != = !=", vec![BangEqual, BangEqual, Equal, BangEqual])
+        lex_test("!= != = !=")
     }
 
     #[test]
     fn braces_brackets_parens() {
-        lex_test(
-            "{([]]}",
-            vec![BraceO, ParenO, BracketO, BracketC, BracketC, BraceC],
-        );
+        lex_test("{([]]}");
     }
 
     #[test]
     fn braces_brackets_parens_whitespace() {
         lex_test(
             "{     (   [      ]         ]   
-            
-            }",
-            vec![BraceO, ParenO, BracketO, BracketC, BracketC, BraceC],
+        
+        }",
         );
     }
 
     #[test]
     fn fancy_stuff() {
-        lex_test(
-            ". ,- * -, .",
-            vec![Dot, Comma, Minus, Asterisk, Minus, Comma, Dot],
-        )
+        lex_test(". ,- * -, .")
     }
 
     #[test]
     fn comments() {
-        lex_test("fn # fn", vec![Fn]);
+        lex_test("fn # fn");
     }
 
     #[test]
     fn long_multiline_comment() {
         lex_test(
             "fn ## hello i am something
-         
-         i span multiple lines
-
-        will you love me? 🥺🥺🥺🥺🥺
-
-    pls :) o(*￣▽￣*)ブ
      
-       i like the indentation here ngl |     sneak for -> ## for ## <- sneak for
-         ## and",
-            vec![Fn, For, And],
+     i span multiple lines
+
+    will you love me? 🥺🥺🥺🥺🥺
+
+pls :) o(*￣▽￣*)ブ
+ 
+   i like the indentation here ngl |     sneak for -> ## for ## <- sneak for
+     ## and",
         )
     }
 
@@ -446,102 +429,50 @@ mod test {
     fn terminate_multiline_comment_correctly() {
         lex_test(
             "fn ## # no not here :( ## let # ## <- this is commented out 
-            # so no multiline comment
-            ## 
-            
-            here it starts
-            # let #
-            # # and
-            ## or
-            ",
-            vec![Fn, Let, Or],
+        # so no multiline comment
+        ## 
+        
+        here it starts
+        # let #
+        # # and
+        ## or
+        ",
         )
     }
 
     #[test]
     fn greeting() {
-        lex_test("-.- /%", vec![Minus, Dot, Minus, Slash, Percent])
+        lex_test("-.- /%")
     }
 
     #[test]
     fn countdown() {
-        lex_test(
-            "3 . . 2 . . 1 . . 0",
-            vec![
-                Number(3.0),
-                Dot,
-                Dot,
-                Number(2.0),
-                Dot,
-                Dot,
-                Number(1.0),
-                Dot,
-                Dot,
-                Number(0.0),
-            ],
-        )
+        lex_test("3 . . 2 . . 1 . . 0")
     }
 
     #[test]
     fn larger_numbers() {
-        lex_test(
-            "123456789, 123456789.1234, 64785903",
-            vec![
-                Number(123456789.0),
-                Comma,
-                Number(123456789.1234),
-                Comma,
-                Number(64785903.0),
-            ],
-        )
+        lex_test("123456789, 123456789.1234, 64785903")
     }
 
     #[test]
     fn string() {
-        lex_test(r#""uwu""#, vec![String("uwu".to_string())])
+        lex_test(r#""uwu""#)
     }
 
     #[test]
     fn strings() {
-        lex_test(
-            r#"(  "hi" "uwu" "\"uwu\""  "no \\ u" )"#,
-            vec![
-                ParenO,
-                String("hi".to_string()),
-                String("uwu".to_string()),
-                String("\"uwu\"".to_string()),
-                String("no \\ u".to_string()),
-                ParenC,
-            ],
-        )
+        lex_test(r#"(  "hi" "uwu" "\"uwu\""  "no \\ u" )"#)
     }
 
     #[test]
     fn keywords() {
-        lex_test(
-            "let fn if else loop while break for true false null and not or print",
-            vec![
-                Let, Fn, If, Else, Loop, While, Break, For, True, False, Null, And, Not, Or, Print,
-            ],
-        )
+        lex_test("let fn if else loop while break for true false null and not or print")
     }
 
     #[test]
     fn keyword_and_ident() {
-        lex_test(
-            "let variable be a loop if false is true",
-            vec![
-                Let,
-                Ident("variable"),
-                Ident("be"),
-                Ident("a"),
-                Loop,
-                If,
-                False,
-                Ident("is"),
-                True,
-            ],
-        )
+        lex_test("let variable be a loop if false is true")
     }
 
     #[test]
@@ -569,61 +500,21 @@ mod test {
             .iter()
             .map(|word| format!("{} ", word))
             .collect::<StdString>();
-        let expected = words.map(TokenKind::Ident).to_vec();
 
-        lex_test(&sentences, expected)
+        lex_test(&sentences)
     }
 
     #[test]
     fn serious_program() {
         lex_test(
             r#"let string = "hallol"
-        let number = 5
-        let me out ._.
-        fn world() {
-            if number == 5 or true == false and not false {
-                println("Hello \\ World!")
-            }
-        }"#,
-            vec![
-                Let,
-                Ident("string"),
-                Equal,
-                String("hallol".to_string()),
-                Let,
-                Ident("number"),
-                Equal,
-                Number(5.0),
-                Let,
-                Ident("me"),
-                Ident("out"),
-                Dot,
-                Ident("_"),
-                Dot,
-                Fn,
-                Ident("world"),
-                ParenO,
-                ParenC,
-                BraceO,
-                If,
-                Ident("number"),
-                EqualEqual,
-                Number(5.0),
-                Or,
-                True,
-                EqualEqual,
-                False,
-                And,
-                Not,
-                False,
-                BraceO,
-                Ident("println"),
-                ParenO,
-                String("Hello \\ World!".to_string()),
-                ParenC,
-                BraceC,
-                BraceC,
-            ],
+    let number = 5
+    let me out ._.
+    fn world() {
+        if number == 5 or true == false and not false {
+            println("Hello \\ World!")
+        }
+    }"#,
         )
     }
 }

src/lib.rs

@@ -10,8 +10,8 @@ mod parse;
 mod vm;
 
 use crate::ast::Program;
-
 use crate::gc::RtAlloc;
+
 pub use bumpalo::Bump;
 pub use lex::*;
 pub use parse::*;

src/parse.rs

@@ -3,7 +3,7 @@
 //! It's a handwritten recursive descent parser. It has an internal peekable iterator from where
 //! it gets its next tokens. Only a lookahead of one is required.
 
-#[cfg(test)]
+#[cfg(test_ignore_lol)]
 mod test;
 
 use crate::ast::*;

src/snapshots/dilaria__lex__test__braces_brackets_parens.snap

@@ -0,0 +1,14 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    BraceO,
+    ParenO,
+    BracketO,
+    BracketC,
+    BracketC,
+    BraceC,
+]

src/snapshots/dilaria__lex__test__braces_brackets_parens_whitespace.snap

@@ -0,0 +1,14 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    BraceO,
+    ParenO,
+    BracketO,
+    BracketC,
+    BracketC,
+    BraceC,
+]

src/snapshots/dilaria__lex__test__comments.snap

@@ -0,0 +1,9 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    Fn,
+]

src/snapshots/dilaria__lex__test__countdown.snap

@@ -0,0 +1,26 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    Number(
+        3.0,
+    ),
+    Dot,
+    Dot,
+    Number(
+        2.0,
+    ),
+    Dot,
+    Dot,
+    Number(
+        1.0,
+    ),
+    Dot,
+    Dot,
+    Number(
+        0.0,
+    ),
+]

src/snapshots/dilaria__lex__test__fancy_stuff.snap

@@ -0,0 +1,15 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    Dot,
+    Comma,
+    Minus,
+    Asterisk,
+    Minus,
+    Comma,
+    Dot,
+]

src/snapshots/dilaria__lex__test__greater_than_less_than_equal.snap

@@ -0,0 +1,14 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    GreaterEqual,
+    LessEqual,
+    EqualEqual,
+    Less,
+    Less,
+    GreaterEqual,
+]

src/snapshots/dilaria__lex__test__greeting.snap

@@ -0,0 +1,13 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    Minus,
+    Dot,
+    Minus,
+    Slash,
+    Percent,
+]

src/snapshots/dilaria__lex__test__keyword_and_ident.snap

@@ -0,0 +1,25 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    Let,
+    Ident(
+        "variable",
+    ),
+    Ident(
+        "be",
+    ),
+    Ident(
+        "a",
+    ),
+    Loop,
+    If,
+    False,
+    Ident(
+        "is",
+    ),
+    True,
+]

src/snapshots/dilaria__lex__test__keywords.snap

@@ -0,0 +1,23 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    Let,
+    Fn,
+    If,
+    Else,
+    Loop,
+    While,
+    Break,
+    For,
+    True,
+    False,
+    Null,
+    And,
+    Not,
+    Or,
+    Print,
+]

src/snapshots/dilaria__lex__test__larger_numbers.snap

@@ -0,0 +1,19 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    Number(
+        123456789.0,
+    ),
+    Comma,
+    Number(
+        123456789.1234,
+    ),
+    Comma,
+    Number(
+        64785903.0,
+    ),
+]

src/snapshots/dilaria__lex__test__long_multiline_comment.snap

@@ -0,0 +1,11 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    Fn,
+    For,
+    And,
+]

src/snapshots/dilaria__lex__test__no_no_no.snap

@@ -0,0 +1,12 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    BangEqual,
+    BangEqual,
+    Equal,
+    BangEqual,
+]

src/snapshots/dilaria__lex__test__not_quite_a_keyword.snap

@@ -0,0 +1,59 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    Ident(
+        "letter",
+    ),
+    Ident(
+        "fori",
+    ),
+    Ident(
+        "fnfn",
+    ),
+    Ident(
+        "iffy",
+    ),
+    Ident(
+        "bloop",
+    ),
+    Ident(
+        "loopy_yeah",
+    ),
+    Ident(
+        "whileTrue",
+    ),
+    Ident(
+        "truefalse",
+    ),
+    Ident(
+        "falsetrue",
+    ),
+    Ident(
+        "nullability",
+    ),
+    Ident(
+        "rot",
+    ),
+    Ident(
+        "ornot",
+    ),
+    Ident(
+        "nor",
+    ),
+    Ident(
+        "andnowQuestionMark",
+    ),
+    Ident(
+        "notOrAnd",
+    ),
+    Ident(
+        "breakMe",
+    ),
+    Ident(
+        "Ibreak",
+    ),
+]

src/snapshots/dilaria__lex__test__serious_program.snap

@@ -0,0 +1,69 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    Let,
+    Ident(
+        "string",
+    ),
+    Equal,
+    String(
+        "hallol",
+    ),
+    Let,
+    Ident(
+        "number",
+    ),
+    Equal,
+    Number(
+        5.0,
+    ),
+    Let,
+    Ident(
+        "me",
+    ),
+    Ident(
+        "out",
+    ),
+    Dot,
+    Ident(
+        "_",
+    ),
+    Dot,
+    Fn,
+    Ident(
+        "world",
+    ),
+    ParenO,
+    ParenC,
+    BraceO,
+    If,
+    Ident(
+        "number",
+    ),
+    EqualEqual,
+    Number(
+        5.0,
+    ),
+    Or,
+    True,
+    EqualEqual,
+    False,
+    And,
+    Not,
+    False,
+    BraceO,
+    Ident(
+        "println",
+    ),
+    ParenO,
+    String(
+        "Hello \\ World!",
+    ),
+    ParenC,
+    BraceC,
+    BraceC,
+]

src/snapshots/dilaria__lex__test__smiley_face.snap

@@ -0,0 +1,13 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    Greater,
+    Greater,
+    Dot,
+    Less,
+    Less,
+]

src/snapshots/dilaria__lex__test__string.snap

@@ -0,0 +1,11 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    String(
+        "uwu",
+    ),
+]

src/snapshots/dilaria__lex__test__strings.snap

@@ -0,0 +1,22 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    ParenO,
+    String(
+        "hi",
+    ),
+    String(
+        "uwu",
+    ),
+    String(
+        "\"uwu\"",
+    ),
+    String(
+        "no \\ u",
+    ),
+    ParenC,
+]

src/snapshots/dilaria__lex__test__terminate_multiline_comment_correctly.snap

@@ -0,0 +1,11 @@
+---
+source: src/lex.rs
+assertion_line: 370
+expression: tokens
+
+---
+[
+    Fn,
+    Let,
+    Or,
+]