add feedback

This commit is contained in:
nora 2024-01-11 22:21:34 +01:00
parent ca18ab0974
commit 8a0b9bf441
6 changed files with 43 additions and 12 deletions

BIN
compiler-errors.jpeg Normal file

Binary file not shown.

After

Width:  |  Height:  |  Size: 40 KiB

BIN
evil-waffle.jpeg Normal file

Binary file not shown.

After

Width:  |  Height:  |  Size: 21 KiB

View file

@ -25,6 +25,9 @@
<ul> <ul>
<li>contributing since 2022</li> <li>contributing since 2022</li>
<li>compiler contributors team since 2023</li> <li>compiler contributors team since 2023</li>
<li>all areas of the compiler</li>
<li>issue triaging</li>
<li>1.74 cargo feature cfg diagnostics</li>
</ul> </ul>
<br> <br>
</div> </div>
@ -34,10 +37,17 @@
</div> </div>
</section> </section>
<section> <section>
<h2>made in collaboration with</h2> <h2>reviewed &hearts;</h2>
<div>you who sees this right now</div> <div style="display: grid; grid-template-columns: 70% auto; align-items: center;">
<div>and you</div> <div>compiler-errors, style team member</div>
<div>and you too</div> <img height="110" src="compiler-errors.jpeg">
<div>WaffleLapkin, the most non-binary compiler contributor</div>
<img height="110" src="waffle.jpeg">
<div>jyn514, the gayest alumni of the bootstrap team</div>
<img height="110" src="jyn.jpeg">
<div>lunasorcery, friend of the above</div>
<img height="110" src="luna.jpeg">
</div>
</section> </section>
<section data-markdown> <section data-markdown>
<textarea data-template> <textarea data-template>
@ -97,12 +107,18 @@
--start 2023-01-01 --end 2023-12-19 --start 2023-01-01 --end 2023-12-19
</code></pre> </code></pre>
<a href="https://github.com/rust-lang/cargo-bisect-rustc">https://github.com/rust-lang/cargo-bisect-rustc</a> <a href="https://github.com/rust-lang/cargo-bisect-rustc">https://github.com/rust-lang/cargo-bisect-rustc</a>
<div>downloads toolchains instead of building them</div>
</section> </section>
<section> <section>
<h2 style="display: flex; justify-content: center; align-items: center;">minimization <img src="E-needs-mcve.png" height="60"></h2> <h2 style="display: flex; justify-content: center; align-items: center;">minimization <img src="E-needs-mcve.png" height="60"></h2>
<div>very useful for fixing an issue</div>
<img src="triage-min-issue.png"> <img src="triage-min-issue.png">
</section> </section>
<section> <section>
<!--
Learn more things about Rust
Can be the start for doing a fix yourself
-->
<h2>minimization</h2> <h2>minimization</h2>
<p>I minimized that issue to 60 lines in 2 hours</p> <p>I minimized that issue to 60 lines in 2 hours</p>
<a href="https://github.com/Nilstrieb/ice-104649">https://github.com/Nilstrieb/ice-104649</a> <a href="https://github.com/Nilstrieb/ice-104649">https://github.com/Nilstrieb/ice-104649</a>
@ -161,10 +177,11 @@
always in need of help! always in need of help!
- rustfmt
- rustup - rustup
- clippy - clippy
- cargo - cargo
- rust-analyzer
- rustfmt
</textarea> </textarea>
</section> </section>
<section data-markdown> <section data-markdown>
@ -175,6 +192,7 @@
- performance improvements - performance improvements
- bug fixes - bug fixes
- APIs are selective
</textarea> </textarea>
</section> </section>
<section data-markdown> <section data-markdown>
@ -190,16 +208,29 @@
<img src="my-first.png"> <img src="my-first.png">
</section> </section>
<section> <section>
<h2>how to</h2> <h2>writing a new trait solver</h2>
<img src="A-diagnostics.png"> <h3>errs.png</3>
<br> </section>
<section>
<h2>Internal compiler-errors fixes</h2>
<div>step 1: become a surgeon</div>
<img src="my-first.png">
</section>
<!-- EXAMPLES (mine) -->
<section>
<h2>rustc dev guide</h2>
<a href="https://rustc-dev-guide.rust-lang.org/">https://rustc-dev-guide.rust-lang.org/</a> <a href="https://rustc-dev-guide.rust-lang.org/">https://rustc-dev-guide.rust-lang.org/</a>
<p>zulip.rust-lang.org, #t-compiler/help</p> </section>
<!-- you can pick another one -->
<section>
<h2>ask for help</h2>
<p>zulip.rust-lang.org, #t-compiler/help</p> <!-- TODO -->
</section> </section>
<section data-markdown> <section data-markdown>
<textarea data-template> <textarea data-template>
## reviews ## looking at prs
- yes <!-- TODO -->
- leave review comments on random PRs - leave review comments on random PRs
</textarea> </textarea>
</section> </section>
@ -210,15 +241,15 @@
</section> </section>
<section data-markdown> <section data-markdown>
<textarea data-template> <textarea data-template>
## review times
- volunteers - volunteers
- weeks - weeks
- rust-lang/rust: ping if >2 weeks - rust-lang/rust: ping if >2 weeks
</textarea> </textarea>
<!-- some of my own contributionsd -->
</section> </section>
<section> <section>
<h2>see you on GitHub!</h2> <h2>see you on GitHub!</h2>
<!-- TODO add all URLs -->
</section> </section>
</div> </div>
</div> </div>

BIN
jyn.jpeg Normal file

Binary file not shown.

After

Width:  |  Height:  |  Size: 21 KiB

BIN
luna.jpeg Normal file

Binary file not shown.

After

Width:  |  Height:  |  Size: 32 KiB

BIN
waffle.jpeg Normal file

Binary file not shown.

After

Width:  |  Height:  |  Size: 12 KiB