I thought it was a good idea, but now that reaper is
not completely busted, i see that this is taking a bit
longer than i'd like.. It's easier to just run reaper again
It transforms "use std::io::{Read, Write}" into
"use std::io::Read; use std::io::Write"
Which later allows to remove just precisely the statements
we do not need, and leave rest be.
The test from the last commit does not pass, but that
is seemingly to do with the test harness setup, since it
works fine locally.
Naively, if we have items (1) foo, (2) foo::bar, (3) foo::baz,
we would try to first try to remove all three of them,
and then if that fails, try to remove just (1) and (2)
..except we should already know that that would fail since it still
includes (1) which covers all three items anyway.
So, try to be smarter about this and not do that.
This is achieved by avoiding ever putting both foo and foo::whatever
in the same try-set, as that gives no information on foo::whatever
regardless of if the check passes or fails
Currently all the use items have the same AstPath,
which means that privatizer tries to change all of them at once.
Which means that if *any* of them can't get privated, then
*all* of them stay unprivated, with all the consequences..
The pass used to (?) track invalidated files itself,
but now that functionality has been moved up one level,
but also kinda not really.
So here we clarify this by:
- making reaper not care about tracking invalidated files anymore
- making processor yes care about tracking invalidated files, and
ensuring that it does not call process_file again after gettin
ProcessState::FileInvalidated, as it advertizes to do.
clap formats the FromStr::Err's arising from parsing the flags
with the Display formatter. This is a very reasonable default
but it also means it loses all the context, since anyhow::Error
only prints the outermost error in Display.
So any failure parsing/creating/loading the function is displayed
to the user as simple "compiling and loading rust function", which
is impossible to debug.
Using the Debug formatting in impl FromStr for RustFunction helps
work around this.
markdown made a breaking change between 1.0.0-alpha.20 and 1.0.0-alpha.21
which made genemichaels stop building.
genemichaels never updated (as a library) to fix that,
so if we want to continue using it we have to ping markdown.
The error:
error[E0599]: no variant or associated item named `BlockQuote` found for enum `Node` in the current scope
--> [path-to]\genemichaels-0.1.21\src\comments.rs:633:15
|
633 | Node::BlockQuote(x) => {
| ^^^^^^^^^^ variant or associated item not found in `Node`
|
help: there is a variant with a similar name
|
633 | Node::Blockquote(x) => {
| ~~~~~~~~~~
